Explicitly mention PythonItemExporter output changes in 2.11 (#6060) #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wRAR
reviewed
Sep 23, 2023
| @@ -40,6 +40,9 @@ Backward-incompatible changes | |||
| UTF-32). If you need to deal with JSON documents in an invalid encoding, | |||
| use ``json.loads(response.text)`` instead. (:issue:`6016`) | |||
|
|
|||
| - :class:`~scrapy.exporters.PythonItemExporter` used the binary output by defauilt | |||
| but it no longer does (:issue:`6006`, :issue:`6007`) | |||
There was a problem hiding this comment.
Suggested change
| but it no longer does (:issue:`6006`, :issue:`6007`) | |
| but it no longer does. (:issue:`6006`, :issue:`6007`) |
wRAR
reviewed
Sep 23, 2023
| @@ -40,6 +40,9 @@ Backward-incompatible changes | |||
| UTF-32). If you need to deal with JSON documents in an invalid encoding, | |||
| use ``json.loads(response.text)`` instead. (:issue:`6016`) | |||
|
|
|||
| - :class:`~scrapy.exporters.PythonItemExporter` used the binary output by defauilt | |||
There was a problem hiding this comment.
Suggested change
| - :class:`~scrapy.exporters.PythonItemExporter` used the binary output by defauilt | |
| - :class:`~scrapy.exporters.PythonItemExporter` used the binary output by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6060