Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more common MS Office file extensions to exclude for documents #6074

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

mikkeschiren
Copy link
Contributor

MS Office Word template file has dotx file ending, I think it could be a good idea to exclude it.

@mikkeschiren mikkeschiren changed the title Add dotx to exclude for documents Add more common MS offiice file extesnions to exclude for documents Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #6074 (523521d) into master (4abc54f) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 523521d differs from pull request most recent head da6e75d. Consider uploading reports for the commit da6e75d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6074      +/-   ##
==========================================
+ Coverage   88.88%   88.95%   +0.06%     
==========================================
  Files         163      163              
  Lines       11571    11571              
  Branches     1876     1876              
==========================================
+ Hits        10285    10293       +8     
+ Misses        975      969       -6     
+ Partials      311      309       -2     
Files Coverage Δ
scrapy/linkextractors/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@wRAR wRAR changed the title Add more common MS offiice file extesnions to exclude for documents Add more common MS offiice file extensions to exclude for documents Sep 29, 2023
@wRAR wRAR changed the title Add more common MS offiice file extensions to exclude for documents Add more common MS Office file extensions to exclude for documents Sep 29, 2023
@wRAR
Copy link
Member

wRAR commented Sep 29, 2023

Thanks!

@wRAR wRAR merged commit 0e64dec into scrapy:master Sep 29, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants