Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the dont_merge_cookies example in docs #6077

Merged
merged 3 commits into from Oct 2, 2023
Merged

Conversation

11-aryan
Copy link
Contributor

@11-aryan 11-aryan commented Oct 1, 2023

  • Removed the whole part about sending custom cookies with dont_merge_cookies from the example
  • Added warning that the custom cookies are ignored when dont_merge_cookies is set to true

Resolves #5936.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #6077 (9dd635d) into master (0e64dec) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 9dd635d differs from pull request most recent head 42adbb2. Consider uploading reports for the commit 42adbb2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6077   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         163      163           
  Lines       11571    11571           
  Branches     1876     1876           
=======================================
  Hits        10293    10293           
  Misses        969      969           
  Partials      309      309           

@wRAR wRAR merged commit a96989c into scrapy:master Oct 2, 2023
26 checks passed
@wRAR
Copy link
Member

wRAR commented Oct 2, 2023

Thanks!

wRAR added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs involving Request.cookies are inaccurate
3 participants