Improved Documentation Fixing Issue #6057 #6080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wRAR
reviewed
Oct 1, 2023
| When you create a spider using the :meth:`Spider.from_crawler()` | ||
| class method, it's important to note that the spider doesn't have all | ||
| its components fully initialized at that point. Some components, such | ||
| as the downloader middleware, are not yet set up. |
wRAR
reviewed
Oct 1, 2023
| To work with a fully initialized spider, consider using the | ||
| `engine_started` signal handler as described in :ref:`engine-started- | ||
| signal-handler`. This ensures that your spider has access to all its | ||
| components. |
|
Also, everything is repeated twice and I don't think this code example is useful here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation for spider.from_crawler() initialization and engine_started signal handler.
The change was adding the code snippet and comments on initialization and using the engine_started handler for fully initialized spiders.
Fixes #6057