Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the Python 3.12 final release #6083

Merged
merged 4 commits into from Oct 3, 2023
Merged

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Oct 2, 2023

No description provided.

@wRAR wRAR added the CI label Oct 2, 2023
@wRAR wRAR marked this pull request as draft October 2, 2023 17:37
@wRAR
Copy link
Member Author

wRAR commented Oct 2, 2023

I guess we need to wait until 3.12 is on the CI servers.

https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #6083 (6ddc978) into master (a96989c) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 6ddc978 differs from pull request most recent head a338873. Consider uploading reports for the commit a338873 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6083   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         163      163           
  Lines       11571    11571           
  Branches     1876     1876           
=======================================
  Hits        10293    10293           
  Misses        969      969           
  Partials      309      309           

@wRAR wRAR marked this pull request as ready for review October 3, 2023 10:27
@Gallaecio Gallaecio mentioned this pull request Oct 3, 2023
3 tasks
@Gallaecio
Copy link
Member

The Windows issue may be legit, related to changes in URL parsing in 3.12 that are more strict. I think even for Windows paths, file:// URLs need to use / as path separator, which may be causing the issue.

@wRAR
Copy link
Member Author

wRAR commented Oct 3, 2023

Looks like the immediate cause is the presence of a colon in the pathURL. Also, there is w3lib in the traceback, we should check its tests too.

@wRAR
Copy link
Member Author

wRAR commented Oct 3, 2023

Though we don't run w3lib tests on Windows.

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wRAR wRAR merged commit 5b0b002 into scrapy:master Oct 3, 2023
25 checks passed
@wRAR wRAR deleted the py3.12-release branch October 3, 2023 16:20
wRAR added a commit that referenced this pull request Nov 16, 2023
Adapt to the Python 3.12 final release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants