Change supported PyPy versions to 3.9 and 3.10. #6087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6087 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 163 163
Lines 11571 11571
Branches 1876 1876
=======================================
Hits 10293 10293
Misses 969 969
Partials 309 309 |
wRAR
commented
Oct 5, 2023
.github/workflows/tests-ubuntu.yml
Outdated
| @@ -38,7 +41,7 @@ jobs: | |||
| - python-version: 3.8.17 | |||
| env: | |||
| TOXENV: asyncio-pinned | |||
| - python-version: pypy3.8 | |||
| - python-version: pypy3.9 | |||
There was a problem hiding this comment.
Not sure about this: this fails because the pinned cryptography is probably too old for 3.9, but pypy3.8 is no longer supported. OTOH in the docs we say that we require Python 3.8+, either CPython or PyPy.
There was a problem hiding this comment.
I would keep it in pypy3.8 is the CI allows it.
Otherwise, we can upgrade the minimum crypto, or require a higher one for 3.9+, and update the docs accordingly.
wRAR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.