Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing hints to CaselessDict and Headers. #6097

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Oct 16, 2023

Fixes #5989

@wRAR wRAR added this to the Scrapy 2.12 milestone Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #6097 (9942d3c) into master (c655679) will decrease coverage by 0.03%.
The diff coverage is 93.33%.

❗ Current head 9942d3c differs from pull request most recent head 26d2497. Consider uploading reports for the commit 26d2497 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6097      +/-   ##
==========================================
- Coverage   88.95%   88.92%   -0.03%     
==========================================
  Files         163      163              
  Lines       11571    11580       +9     
  Branches     1876     1878       +2     
==========================================
+ Hits        10293    10298       +5     
- Misses        969      971       +2     
- Partials      309      311       +2     
Files Coverage Δ
scrapy/core/http2/stream.py 91.90% <100.00%> (ø)
scrapy/http/request/__init__.py 97.82% <100.00%> (ø)
scrapy/http/response/__init__.py 100.00% <100.00%> (ø)
scrapy/http/response/text.py 98.42% <100.00%> (ø)
scrapy/http/headers.py 95.94% <93.93%> (-2.59%) ⬇️
scrapy/utils/datatypes.py 98.14% <90.00%> (-1.86%) ⬇️

@Gallaecio Gallaecio merged commit 5807970 into scrapy:master Oct 17, 2023
26 checks passed
@wRAR wRAR deleted the typing-headers-simple branch October 18, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type annotation of "headers" argument of scrapy.Request is incomplete
2 participants