Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated support from scrapy.utils.log.logformatter_adapter() #6109

Closed
wRAR opened this issue Oct 17, 2023 · 1 comment · Fixed by #6116
Closed

Remove deprecated support from scrapy.utils.log.logformatter_adapter() #6109

wRAR opened this issue Oct 17, 2023 · 1 comment · Fixed by #6116
Labels
cleanup good first issue

Comments

@wRAR
Copy link
Member

wRAR commented Oct 17, 2023

This helper was added in 1.0.0 (I think), it looks like the parts of it that don't show warnings are still useful, though I haven't looked closely at them.
@Chenwei-Niu Chenwei-Niu mentioned this issue Oct 18, 2023
Merged
@wRAR
Copy link
Member Author

wRAR commented Oct 25, 2023

@rishabhRsinghvi you don't need to be assigned to work on something, but also this issue already has a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed some deprecated functions and supports Chenwei-Niu/scrapy
1 participant
@wRAR