Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full typing for scrapy/spidermiddlewares. #6130

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Nov 2, 2023

I've removed the or () parts because result shouldn never be None (well, because mypy said async for r in () is incorrect code and I looked at it closely).

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #6130 (7857844) into master (593bfd8) will increase coverage by 0.02%.
The diff coverage is 90.67%.

❗ Current head 7857844 differs from pull request most recent head e54dc59. Consider uploading reports for the commit e54dc59 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6130      +/-   ##
==========================================
+ Coverage   88.71%   88.73%   +0.02%     
==========================================
  Files         160      160              
  Lines       11428    11473      +45     
  Branches     1862     1867       +5     
==========================================
+ Hits        10138    10181      +43     
  Misses        979      979              
- Partials      311      313       +2     
Files Coverage Δ
scrapy/spidermiddlewares/depth.py 94.11% <88.23%> (-3.56%) ⬇️
scrapy/spidermiddlewares/httperror.py 95.45% <88.23%> (-4.55%) ⬇️
scrapy/spidermiddlewares/offsite.py 95.71% <90.90%> (-2.70%) ⬇️
scrapy/spidermiddlewares/urllength.py 84.37% <87.50%> (-3.63%) ⬇️
scrapy/spidermiddlewares/referer.py 92.54% <93.47%> (-0.70%) ⬇️

... and 1 file with indirect coverage changes

@wRAR wRAR merged commit f356180 into scrapy:master Nov 3, 2023
25 checks passed
@wRAR wRAR deleted the typing-spider-mw branch November 3, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants