Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrapy.utils.data_path type hint change #6133

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

cakemd
Copy link
Contributor

@cakemd cakemd commented Nov 3, 2023

Updating type hint for scrapy.utils.project.data_path.

This is a small change which brings a part of solution of the issue #5739.

The type hint change was suggested here.

scrapy/utils/project.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #6133 (e6a7bb2) into master (04024f1) will decrease coverage by 0.01%.
Report is 9 commits behind head on master.
The diff coverage is 91.92%.

❗ Current head e6a7bb2 differs from pull request most recent head 476ff5e. Consider uploading reports for the commit 476ff5e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6133      +/-   ##
==========================================
- Coverage   88.75%   88.74%   -0.01%     
==========================================
  Files         160      160              
  Lines       11414    11475      +61     
  Branches     1860     1867       +7     
==========================================
+ Hits        10130    10183      +53     
- Misses        976      979       +3     
- Partials      308      313       +5     
Files Coverage Δ
scrapy/core/downloader/handlers/datauri.py 94.11% <100.00%> (+0.78%) ⬆️
scrapy/core/scraper.py 85.26% <100.00%> (+0.07%) ⬆️
scrapy/http/common.py 100.00% <100.00%> (ø)
scrapy/http/request/__init__.py 97.82% <100.00%> (ø)
scrapy/http/request/json_request.py 94.59% <100.00%> (ø)
scrapy/http/request/rpc.py 100.00% <100.00%> (ø)
scrapy/utils/project.py 79.62% <100.00%> (+0.78%) ⬆️
scrapy/utils/ssl.py 61.36% <100.00%> (ø)
scrapy/http/response/text.py 98.43% <96.15%> (+0.01%) ⬆️
scrapy/http/request/form.py 94.69% <77.77%> (-1.46%) ⬇️
... and 6 more

... and 1 file with indirect coverage changes

@wRAR
Copy link
Member

wRAR commented Nov 3, 2023

Can you please also install and use pre-commit as described at https://docs.scrapy.org/en/latest/contributing.html#pre-commit ?

@cakemd
Copy link
Contributor Author

cakemd commented Nov 3, 2023

@wRAR sure, done. Thanks.

@Gallaecio Gallaecio merged commit eafe828 into scrapy:master Nov 6, 2023
25 checks passed
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants