Simplify create_instance calls
#6162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6162 +/- ##
==========================================
+ Coverage 88.59% 88.61% +0.01%
==========================================
Files 159 159
Lines 11582 11600 +18
Branches 1885 1889 +4
==========================================
+ Hits 10261 10279 +18
Misses 994 994
Partials 327 327
|
Gallaecio
reviewed
Dec 15, 2023
Gallaecio
reviewed
Dec 15, 2023
Gallaecio
reviewed
Dec 15, 2023
There was a problem hiding this comment.
It is a good first step, but there is some more work to do, such as:
- Logging a deprecation warning when
create_instanceis called. - Replacing all usages of
create_instancein the code base by one of these new functions.
For the record, I’m reviewing #6169 at the moment and it seems closer to completion.
|
Hi @Gallaecio, thanks for responding, I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
build_from_crawlerandbuild_from_settingsfunctionsFixes #5523, closes #5884, closes #6169.