resolve issue 5932 #6178
Closed
resolve issue 5932 #6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6178 +/- ##
===========================================
- Coverage 88.75% 43.18% -45.57%
===========================================
Files 160 159 -1
Lines 11414 11581 +167
Branches 1860 1885 +25
===========================================
- Hits 10130 5001 -5129
- Misses 976 6188 +5212
- Partials 308 392 +84
|
|
It seems this approach breaks some feedexport scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5932
Removed the lines closing the temporary file in GzipPlugin, Bz2Plugin, and LMZAPlugin in postprocessing.py.
Placed file closes in GCSFeedExporter, FTPFeedStorage, and S3FeedStorage in feedexport.py.