Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release logs for response_httprepr removal #6216

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

Andy-W-Developer
Copy link
Contributor

Resolves #6207

@Andy-W-Developer Andy-W-Developer marked this pull request as ready for review February 4, 2024 11:15
@wRAR
Copy link
Member

wRAR commented Feb 4, 2024

It was deprecated in 2.6.0, not in 2.10.0.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Merging #6216 (5317687) into master (6f73dc0) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6216      +/-   ##
==========================================
+ Coverage   88.48%   88.55%   +0.06%     
==========================================
  Files         160      160              
  Lines       11607    11607              
  Branches     1883     1883              
==========================================
+ Hits        10271    10279       +8     
+ Misses       1009     1003       -6     
+ Partials      327      325       -2     

see 1 file with indirect coverage changes

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Gallaecio Gallaecio merged commit 1c9d308 into scrapy:master Feb 5, 2024
26 checks passed
@Andy-W-Developer Andy-W-Developer deleted the update-documentation branch February 25, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the deprecation and removal of response_httprepr
3 participants