Solve incompatibility errors in _compression.py

[ygalvao]

Increase compatibility across different virtual environments, particularly with Conda, when using brotli.Decompressor()

[wRAR]

Is this only required when brotlipy is installed instead of/in addition to brotli?

[ygalvao]

Yes. I don't know why, but when setting up conda environments and installing scrapy and other packages it seems Conda / Mamba only installs brotlipy.

[Gallaecio]

Maybe we should do something to make Scrapy distinguish the 2, and only enable brotli support when the right one is installed.

[wRAR]

Yeah.

[wRAR]

when setting up conda environments and installing scrapy and other packages it seems Conda / Mamba only installs brotlipy.

Note that Scrapy currently does not depend on brotli (or on brotlipy), neither on PyPI nor on Conda, and if something installs brotlipy as opposed to not installing anything it's either "other packages" you mentioned or some other things you do when "setting up".

[ygalvao]

I understand. However, in my current conda env I just have a few packages installed, most of them are well-known ones like Scrapy, Selenium, Pandas, Numpy, etc. and somehow, Conda or Mamba installed brotlipy, which throws an AttributeError when running Scrapy. So this simple change solves this issue, adding compatibility with brotlipy and hence with other packages installed using Conda / Mamba as well.

[codecov]

Codecov Report

Merging #6261 (9cbdacb) into master (ee51958) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6261   +/-   ##
=======================================
  Coverage   88.89%   88.90%           
=======================================
  Files         161      161           
  Lines       11776    11786   +10     
  Branches     1913     1913           
=======================================
+ Hits        10468    10478   +10     
  Misses        964      964           
  Partials      344      344           

Files	Coverage Δ
scrapy/utils/_compression.py	91.89% <100.00%> (+1.26%)	⬆️