Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowsRunSpiderCommandTest isn't skipped properly in the pinned envs #6286

Closed
wRAR opened this issue Mar 9, 2024 · 0 comments · Fixed by #6290
Closed

WindowsRunSpiderCommandTest isn't skipped properly in the pinned envs #6286

wRAR opened this issue Mar 9, 2024 · 0 comments · Fixed by #6290
Labels

Comments

@wRAR
Copy link
Member

wRAR commented Mar 9, 2024

0025134 was incorrect as, it turned out, top-level unittest.skipIf support for twisted.trial.unittest tests was added only in Twisted 21.2.0 and we install 18.9.0 in the pinned envs, but for some reason the test was still skipped. Today pytest 8.1.1 was released and the problem is now visible (I don't see anything related in the changelog but then I don't know why the test is skipped in 8.0.2 and earlier), so the test fails on pinned envs on Linux instead of being skipped.

We can revert the linked commit, raise the minimum supported Twisted version to 21.2.0 (it's also the first version officially supporting Python 3.8 which itself was released in Oct 2019, so a year later than Twisted 18.9.0), or add some more complicated code that skips the individual methods only for older Twisted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant