Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6328. Document 'json' selector type #6334

Merged
merged 1 commit into from
May 6, 2024

Conversation

kumar-sanchay
Copy link
Contributor

added json as one of the value for type argument.
Closes #6328

added json as one of the value for type argument
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (d7da298) to head (afaa256).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6334      +/-   ##
==========================================
+ Coverage   83.88%   88.45%   +4.57%     
==========================================
  Files         161      161              
  Lines       12010    12010              
  Branches     1929     1867      -62     
==========================================
+ Hits        10075    10624     +549     
+ Misses       1598     1030     -568     
- Partials      337      356      +19     
Files Coverage Δ
scrapy/selector/unified.py 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

@Gallaecio Gallaecio merged commit aa025d7 into scrapy:master May 6, 2024
26 checks passed
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'json' selector type not documented
2 participants