Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed than
tox -e twinecheck
prints many warnings and this led to updatingMANIFEST.in
to the current project state. I couldn't add--strict
totwine check
though, because bothprune docs/build
andglobal-exclude __pycache__ *.py[cod]
cause warnings about no files affected.Some lines are removed because they are on by default, following https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html. I also used https://pypi.org/project/check-sdist/ to see that the following files are omitted:
which looks OK to me.
Not sure if we should add
check-sdist
to CI.