Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MANIFEST.in. #6344

Merged
merged 1 commit into from
May 8, 2024
Merged

Update MANIFEST.in. #6344

merged 1 commit into from
May 8, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented May 7, 2024

I noticed than tox -e twinecheck prints many warnings and this led to updating MANIFEST.in to the current project state. I couldn't add --strict to twine check though, because both prune docs/build and global-exclude __pycache__ *.py[cod] cause warnings about no files affected.

Some lines are removed because they are on by default, following https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html. I also used https://pypi.org/project/check-sdist/ to see that the following files are omitted:

  .bandit.yml
  .bumpversion.cfg
  .coveragerc
  .flake8
  .git-blame-ignore-revs
  .gitattributes
  .gitignore
  .isort.cfg
  artwork/README.rst
  artwork/qlassik.zip
  artwork/scrapy-blog-logo.xcf
  artwork/scrapy-logo.jpg
  pylintrc
  sep/README.rst
  sep/sep-001.rst
  sep/sep-002.rst
  sep/sep-003.rst
  sep/sep-004.rst
  sep/sep-005.rst
  sep/sep-006.rst
  sep/sep-007.rst
  sep/sep-008.rst
  sep/sep-009.rst
  sep/sep-010.rst
  sep/sep-011.rst
  sep/sep-012.rst
  sep/sep-013.rst
  sep/sep-014.rst
  sep/sep-015.rst
  sep/sep-016.rst
  sep/sep-017.rst
  sep/sep-018.rst
  sep/sep-019.rst
  sep/sep-020.rst

which looks OK to me.

Not sure if we should add check-sdist to CI.

@wRAR wRAR added the bug label May 7, 2024
@wRAR
Copy link
Member Author

wRAR commented May 7, 2024

(not sure why .github/ is not listed, I think it's not in the sdist tarball either)

@wRAR wRAR merged commit 4300a1d into scrapy:master May 8, 2024
25 checks passed
@wRAR wRAR deleted the fix-twinecheck branch May 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants