Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in dropdown in editor shows translation ids instead of readable text #3601

Closed
benjiwheeler opened this issue Nov 1, 2018 · 2 comments
Closed
Assignees
Milestone

Comments

@benjiwheeler
Copy link
Contributor

When using editor while embedded in www, the sign in dropdown appears as:

screen shot 2018-11-01 at 2 28 17 pm

The problem is that we're actually passing jsx from www to gui, including several www-style <FormattedMessage />. These message id's aren't defined within gui, so gui does not know their translations, and within gui's scope, www's intl does not apply.

@benjiwheeler
Copy link
Contributor Author

Reopening because this is fixed in the code (and appears correctly for all languages except English), but needs translations to be built with English included (they haven't been until now) for this to appear fixed in English.

@benjiwheeler
Copy link
Contributor Author

Finally confirmed that this works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant