Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile doesn't accept folders with spaces in the name #66

Closed
evhan55 opened this issue Aug 6, 2018 · 3 comments
Closed

Makefile doesn't accept folders with spaces in the name #66

evhan55 opened this issue Aug 6, 2018 · 3 comments
Labels
bug Something isn't working ergonomics
Milestone

Comments

@evhan55
Copy link
Contributor

evhan55 commented Aug 6, 2018

Expected:

Running make doesn't give errors.

Observed:

When running make in the macOS directory, it would error out if a folder name in one of the paths containing the repo had a space in the name. Example folder name: git repos.

Workaround:

Changing the folder from git repos to repos lets the make script run to completion, but perhaps this can be fixed to not need that as an enhancement in the future.

@thisandagain thisandagain added bug Something isn't working ergonomics labels Aug 20, 2018
@thisandagain thisandagain added this to the Backlog milestone Aug 20, 2018
@cwillisf
Copy link
Contributor

cwillisf commented Aug 24, 2018

I spent a little bit of time investigating this and it turns out to basically be a limitation of GNU Make, or Make in general. I tried a few different approaches and I think we can't really fix it unless we change build systems away from Make.

See also: http://savannah.gnu.org/bugs/?712

@evhan55
Copy link
Contributor Author

evhan55 commented Aug 25, 2018

Oh, interesting! Good to know, maybe could add to documentation somewhere?

@cwillisf
Copy link
Contributor

This was added to the repository README.md a while ago but I forgot to close this issue. Closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ergonomics
Projects
None yet
Development

No branches or pull requests

3 participants