Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Quirks mode" SVG import #519

Closed
cwillisf opened this issue Apr 4, 2017 · 0 comments
Closed

"Quirks mode" SVG import #519

cwillisf opened this issue Apr 4, 2017 · 0 comments
Milestone

Comments

@cwillisf
Copy link
Contributor

cwillisf commented Apr 4, 2017

Expected Behavior

Many Scratch 2.0 SVG images have incorrect bounds or offset information. The VM (or perhaps the GUI, or some other import-related module) should "fix up" such an SVG when necessary before handing it off to the renderer.

Handling the fix-up outside the renderer means that we know when to apply the fix-up (only when importing a broken SVG) and also means that an alternative renderer would not need to duplicate the fix-up code.

Actual Behavior

The VM supplies SVGs to the renderer as-is and expects the renderer to handle the "quirks mode" rendering.

Steps to Reproduce

See scratchfoundation/scratch-render#116, scratchfoundation/scratch-render#117, and scratchfoundation/scratch-render#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants