Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credits page is no longer in Alphabetical Order #3813

Closed
Accio1 opened this issue Apr 17, 2020 · 7 comments · Fixed by #3836
Closed

Credits page is no longer in Alphabetical Order #3813

Accio1 opened this issue Apr 17, 2020 · 7 comments · Fixed by #3836

Comments

@Accio1
Copy link
Contributor

Accio1 commented Apr 17, 2020

Since #3805 removed the last names from the credits page, the order that Scratch Team members are listed on the page doesn't make sense. They used to be ordered alphabetically by last name, but now since the last names are removed, they appear to be in a random order.

They should be reordered to be alphabetical by first name so that the page makes more sense.

Steps to Reproduce

  1. Go to the credits page
  2. Observe that the Scratch Team members appear to be in a random order.

Operating System and Browser

This would appear on any device and browser

@Accio1
Copy link
Contributor Author

Accio1 commented Apr 17, 2020

I would be able to fix this if the Scratch Team agrees that it needs to be fixed.

@Accio1
Copy link
Contributor Author

Accio1 commented Apr 27, 2020

@BryceLTaylor is this something that the Scratch Team would like fixed?

@BryceLTaylor
Copy link
Contributor

@Accio1 We would love it if you fixed it.

@Accio1
Copy link
Contributor Author

Accio1 commented Apr 28, 2020

@Accio1 We would love it if you fixed it.

Great! I'll be able to start after #3830 is merged, because that affects the credits page as well, and starting before that was merged could cause conflicts (I think).

@benjiwheeler
Copy link
Contributor

benjiwheeler commented Apr 29, 2020

@Accio1 OK, 3830 is merged! When you submit a PR for this, please tag me, and I'll review it.

@benjiwheeler benjiwheeler self-assigned this Apr 29, 2020
@benjiwheeler benjiwheeler added this to the April 2020 milestone Apr 29, 2020
@Accio1
Copy link
Contributor Author

Accio1 commented Apr 29, 2020

@Accio1 OK, 3830 is merged! When you submit a PR for this, please tag me, and I'll review it.

@benjiwheeler Ok, I've started working on it. I just had one question. What should I do if more than one person has the same name. (eg. there are two Chris and two Mark)? Should the person with their username first in the alphabet come first?

@benjiwheeler
Copy link
Contributor

Good question. Sure, then alphabetize by username, that sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants