New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #8: Add support for Some(*patterns) that matches subsequences #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scravy
changed the title
Fix issue 8: Add support for Some(*patterns) that matches subsequences
Fix issue #8: Add support for Some(*patterns) that matches subsequences
Jan 1, 2022
scravy
force-pushed
the
fix-issue-8
branch
2 times, most recently
from
January 2, 2022 04:36
a802445
to
f7a70e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
Some(*)
to match subsequences.Previously
Some(...)
would only match individiual items, i.e. the pattern[0, Some(1), 2]
would match the value[0, 1, 1, 1, 2]
. Compared with a regex on strings this would be like01*2
but the repetition here could not be applied to subsequences0(12)*3
. This pull request introduces the ability forSome(*)
to take multiple patterns which it then tries to match as a sequence within:[0, Some(1, 2), 3]
would now match the value[0, 1, 2, 1, 2, 3]
. This could not be expressed before.Note that the new syntax is different from
Some([1, 2])
as this would match items which are themselves lists, i.e.[0, [1, 2], [1, 2], 3]
.