Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawnCreep should automatically assign a name #55

Closed
NobodysNightmare opened this issue Sep 29, 2017 · 2 comments
Closed

spawnCreep should automatically assign a name #55

NobodysNightmare opened this issue Sep 29, 2017 · 2 comments

Comments

@NobodysNightmare
Copy link

NobodysNightmare commented Sep 29, 2017

I just noticed that spawnCreep (as opposed to createCreep) does not automatically assign a name to created creeps anymore.

I think this is an unneccessary complication for new players, which should not use a deprecated method like createCreep, should they?

Was there a particular reason to leave that behaviour out? The pull request does not at all mention this change, I discovered it by chance after seeing that my spawning code does not work after changing to the new method signature.

edit: In case you want to keep the behaviour as is, the documentation of return values should be updated. Currently it only points at an errorneous creep body, but not at a missing name.

@Angoulor
Copy link

I agree with this. Even though there's a limited number of names, and problems with scalability, I feel like new players will prefer to create a naming function later. They won't really care for their creeps' names right at the beginning.

@artch artch closed this as completed Sep 29, 2017
@artch
Copy link
Contributor

artch commented Sep 29, 2017

Please create new issues only for bug reports and other technical issues. Your discussion is more appropriate to the original PR thread or forum post thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants