Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta post pull request comments is noisy #1714

Open
anilkumarmyla opened this issue Aug 8, 2019 · 5 comments · Fixed by screwdriver-cd/scm-github#152
Open

Meta post pull request comments is noisy #1714

anilkumarmyla opened this issue Aug 8, 2019 · 5 comments · Fixed by screwdriver-cd/scm-github#152

Comments

@anilkumarmyla
Copy link

What happened:
Meta post pull request comments is noisy if multiple commits/multiple builds happen for a pull-request

What you expected to happen:
Ability to tweak the behavior of posting comments to only updating the same comment or deleting old comment and adding new comment. For reference codecov bot has pull request comments behavior https://docs.codecov.io/docs/pull-request-comments#section-behavior which can tweak the post comments behavior

How to reproduce it:
Open a PR, start multiple builds for the same commit or have multiple commits trigger build. Each build posts a new comment

@jithine jithine added the feature label Aug 8, 2019
@tkyi
Copy link
Member

tkyi commented Aug 8, 2019

This should be doable. Might be easiest to just update the comment rather than try to delete and create. I don't think this necessarily would need to be configurable. Users should be able to see edit history of comment if they really want to look at old comments.

Screen Shot 2019-08-08 at 2 03 29 PM

Implementation

  • Will probably need to add logic in scm-github to check if a comment exists which has a user.login that matches sd-buildbot/the default commenter.
    • If it exists, get the ID and update the comment.
    • If it doesn't exist, create a new comment (current behavior).
  • Probably do not need to change models.

@anilkumarmyla
Copy link
Author

👍

@supra08
Copy link
Contributor

supra08 commented Mar 15, 2020

Hi @tkyi! I would like to work on this issue.

@jithine
Copy link
Member

jithine commented Jun 2, 2020

Looks like edit is not working and is creating new comments.

@tkyi tkyi moved this from Done to Summer of Code in Active Work Aug 4, 2020
@tkyi tkyi removed this from Summer of Code in Active Work Mar 17, 2021
@jithine
Copy link
Member

jithine commented Oct 18, 2021

@dwighthubbard looks like this is a known issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Active Work
Awaiting triage
Development

Successfully merging a pull request may close this issue.

4 participants