Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request which spans multiple pipelines sometimes fail to start all jobs #2640

Closed
jithine opened this issue Jan 21, 2022 · 2 comments
Closed
Labels
Projects

Comments

@jithine
Copy link
Member

jithine commented Jan 21, 2022

What happened:
We notices an instance where a Pull Request which was supposed to start 18 jobs was not starting all of them.

{ "level": "error", "message": "[e2eab260-7971-11ec-9b73-901c677be0cd]: SequelizeUniqueConstraintError: Validation error", "timestamp": "2022-01-19T21:51:09.693Z" }
20119/215059.000, (1642629059000:sdapi-7f48cc6446-thlcw:27:kyeapnkn:63693) [response,api,webhook] 

What you expected to happen:

Erroneous pipelines should not block rest of jobs from starting up. In this instance there was an error in one of the pipelines (probably) which prevents all events from being processed properly.
Expectation would be SD API should run all jobs which can run and log the ones which it's unable to run.

How to reproduce it:

N/A

@jithine jithine added the bug label Jan 21, 2022
@jithine jithine added this to Doing in Active Work Jan 21, 2022
@jithine jithine changed the title Pull Request which spans multiple pipelines fails to start all jobs Pull Request which spans multiple pipelines sometimes fail to start all jobs Jan 21, 2022
@jithine
Copy link
Member Author

jithine commented Jan 25, 2022

@jithine jithine closed this as completed Jan 26, 2022
@jithine jithine moved this from Doing to Verify in Active Work Jan 26, 2022
@jithine jithine reopened this Feb 2, 2022
@jithine
Copy link
Member Author

jithine commented Feb 2, 2022

this issue is caused by a DB unique key constraint which is not quite valid for a single git repo with multiple pipelines created with source dir.

https://github.com/screwdriver-cd/data-schema/blame/master/models/event.js#L169

All such events will same same sha and potentially same createTime We need to either undo the DB constraint or make event creation sequential.

@jithine jithine moved this from Verify to Doing in Active Work Feb 2, 2022
@jithine jithine moved this from Doing to Verify in Active Work Feb 4, 2022
@jithine jithine closed this as completed Feb 4, 2022
@tkyi tkyi moved this from Verify to Done in Active Work Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

1 participant