feat(1710): support external join. BREAKING CHANGE: add new external join logic [4] #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2lam
changed the title
d2lam
force-pushed
the
external
branch
2 times, most recently
from
9bf0e10
to
0f33d35
Compare
d2lam
changed the title
tkyi
reviewed
Oct 30, 2019
tkyi
reviewed
Oct 30, 2019
tkyi
reviewed
Oct 30, 2019
lib/getWorkflow.js
Outdated
| }); | ||
|
|
||
| await buildExternalNodes( | ||
| jobName, externalDownstreamAnd, nodes, triggerFactory); |
There was a problem hiding this comment.
Suggested change
| jobName, externalDownstreamAnd, nodes, triggerFactory); | |
| srcName, externalDownstreamAnd, nodes, triggerFactory); |
tkyi
reviewed
Oct 30, 2019
tkyi
reviewed
Oct 30, 2019
tkyi
reviewed
Oct 30, 2019
DekusDenial
reviewed
Nov 4, 2019
test/lib/getWorkflow.test.js
Outdated
| it('should throw if it is not given correct input', () => { | ||
| assert.throws(() => getWorkflow({ config: {} }), | ||
| Error, 'No Job config provided'); | ||
| describe.only('getWorkflow', () => { |
tkyi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: screwdriver-cd/screwdriver#1710
Blocked by: screwdriver-cd/config-parser#94
Previously, we only include nodes & edges from the workflow graph. This PR will generate external nodes & external edges that are downstream for each job.