fix: refactor getDestFromSrc #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wahapo
commented
Jan 13, 2022
| @@ -3,27 +3,27 @@ | |||
| { "name": "~pr" }, | |||
| { "name": "~commit" }, | |||
| { "name": "A" }, | |||
| { "name": "sd@777:external-level1" }, | |||
There was a problem hiding this comment.
The order seems to change a bit.
itleigns
approved these changes
Jan 14, 2022
y-oksaku
reviewed
Jan 14, 2022
lib/getWorkflow.js
Outdated
| * @param {Number} pipelineId Id of the current pipeline | ||
| * @param {Object} jobs Hash of job configurations | ||
| * @param {TriggerFactory} triggerFactory Trigger Factory to find external triggers | ||
| * @param {Number} pipelineId Id of the current pipeline |
There was a problem hiding this comment.
[nits] pipelineId was removed.
kumada626
approved these changes
Jan 17, 2022
yoshwata
approved these changes
Jan 18, 2022
jithine
approved these changes
Jan 18, 2022
tkyi
approved these changes
Jan 18, 2022
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
triggerFactory.getDestFromSrc()is called a number of times proportional to the number of jobs defined in the pipeline. (source-code)Since
getDestFromSrc()executes heavy queries to the DB, the number of times it should be reduced as much as possible.It is called with the same argument in
calculateNodes()andcalculateEdges(), and the number of times it is called increases tremendously as the number of jobs increases.Objective
I refactored it to halve the number of calls in
calculateNodes()andcalculateEdges().References
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.