feat(3022): Mark workflow node as virtual if it corresponds to a virtual job #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
Mar 11, 2024
Comment on lines
+97
to
+104
| annotations.forEach(({ annotation, fieldName, defaultValue }) => { | ||
| const fieldValue = hoek.reach(jobs[name], annotation, { | ||
| separator: '>', | ||
| default: defaultValue | ||
| }); | ||
|
|
||
| if (fieldValue !== undefined) { | ||
| m[fieldName] = fieldValue; |
There was a problem hiding this comment.
small suggestion: is using value a little redundant for variable names?
Suggested change
| annotations.forEach(({ annotation, fieldName, defaultValue }) => { | |
| const fieldValue = hoek.reach(jobs[name], annotation, { | |
| separator: '>', | |
| default: defaultValue | |
| }); | |
| if (fieldValue !== undefined) { | |
| m[fieldName] = fieldValue; | |
| annotations.forEach(({ annotation, fieldName, default }) => { | |
| const field = hoek.reach(jobs[name], annotation, { | |
| separator: '>', | |
| default | |
| }); | |
| if (field !== undefined) { | |
| m[fieldName] = field; |
There was a problem hiding this comment.
Changing it to just field may not make more sense as it represents value.
May be we could use just value. Since we are using fieldName for the key, fieldValue seems more appropriate to represent the value.
There was a problem hiding this comment.
Also default is a keyword and cannot be used as variable name.
sagar1312
force-pushed
the
sagar1312-feat-3022-virtual_setup_teardown_jobs
branch
from
fa50387
to
fd0dc65
Compare
tkyi
approved these changes
Mar 12, 2024
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Workflow graph node (Ex: implicit setup/teardown job of a stage) for an event is identified as virtual based on the presence/value of
screwdriver.cd/virtualJobannotation in the corresponding job definition.Since the job definition reflects the latest configuration from
screwdriver.yaml, referring to current annotations of the job may not be reliable to identify it as virtual for an event.We need a way to preserve whether the job is virtual or not when event is created.
Objective
Add a new attribute
virtualin the workflow graphnodeto indicate whether it is virtual or not.References
screwdriver-cd/screwdriver#3022
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.