Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add period and comma to letter keys on menu selection #308

Closed
2 tasks done
andrewtavis opened this issue May 21, 2023 · 3 comments
Closed
2 tasks done

Add period and comma to letter keys on menu selection #308

andrewtavis opened this issue May 21, 2023 · 3 comments
Assignees
Labels
blocked Another issue is blocking feature New feature or request GSoC Available for Google Summer of Code participants help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

This issue would be to implement the change to the keyboard that would be triggered by the menu item in #196. If the user chooses to include a period and comma in the letter keys via the menu, then a period would appear to the left of the spacebar and a comma to the right of the spacebar for letter keys, number keys and special keys.

Contribution

This issue will be done as a part of Google Summer of Code 2023 :) Happy to support where needed!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed blocked Another issue is blocking GSoC Available for Google Summer of Code participants labels May 21, 2023
@SaurabhJamadagni
Copy link
Collaborator

Hey @andrewtavis! I just wanted to update you on the progress of this issue. I was able to figure out how to check if the user has the extensions installed. I also figured out establishing common data stores so different targets can save their preferences.

I haven't pushed the changes yet as it's a bit buggy right now and I'm trying to identify that problem. To be specific, currently it won't reload the list when a user adds or removes a language from Settings. Trying to figure out where would be a good place to refresh.

I am sorry on the delay. But I'm a bit occupied with last minute shopping and packing for the move. I'll share the changes soon. Just wanted to inform about the delay 😅

@andrewtavis
Copy link
Member Author

No stress, @SaurabhJamadagni! Appreciate the efforts and am looking forward to the changes! 🚀 I definitely understand that it’s tough to find a spot to refresh sometimes :)

Good luck with the move! Hope that it all goes well 🚚😊

@andrewtavis
Copy link
Member Author

Resolved via #340 :) :) Thanks @SaurabhJamadagni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Another issue is blocking feature New feature or request GSoC Available for Google Summer of Code participants help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants