complete option in ChronologyParams

[josephlarralde]

I just came across these lines while trying to refactor the Chronology class :

libMidifilePerformer/src/include/core/Chronology.h

Lines 169 to 171 in 4401684

	// If it IS empty, register the bufferSet as incomplete.
	if (params.complete && insertSet.events.empty())
	incompleteEvents.push_back({bufferSet,&fifo.back()});

I'm wondering if it is sufficient to check if bufferSet is incomplete : what if insertSet is not empty but not all start events in bufferSet have a matching end in insertSet ? I didn't actually try it though ...

Meanwhile, I'm in the process of refactoring the core in order to make the base Renderer class template lighter, and implementing various types of Renderers on top of it, so I'm starting to think that the "complete" logic could be handled by a specific Renderer implementation, instead of being handled by the Chronology.

I'll keep it in the Chronology for now, but I think it's worth considering the alternative (rewrite in C++ the original naive JS code that only takes start events into account and generates the end events according to the commands).