Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dist folder option #115

Closed
scriptPilot opened this issue Dec 25, 2022 · 3 comments · Fixed by #117
Closed

Dist folder option #115

scriptPilot opened this issue Dec 25, 2022 · 3 comments · Fixed by #117
Assignees
@scriptex
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@scriptPilot
Copy link

scriptPilot commented Dec 25, 2022 •
edited

Thanks for this piece of code - very helfpul.

Enhancement:

Would be helpful to specify in the CLI call the dist folder where all files and folders are generated.
Today, they are all created in the main folder.
@scriptex scriptex linked a pull request Dec 28, 2022 that will close this issue
Updates #117
Merged
@scriptex scriptex self-assigned this Dec 28, 2022
@scriptex scriptex added enhancement New feature or request good first issue Good for newcomers labels Dec 28, 2022
@scriptex
Copy link
Owner

Thanks for raising this, it looks like a nice improvement!
I will include it in the upcoming release.
For more details please check out the PR.

@scriptex
Copy link
Owner

This is added as a new CLI flag --output in the latest release which is available on Github and NPM.

@scriptPilot
Copy link
Author

Thanks a lot for the quick implementation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scriptex scriptex

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates scriptex/create-pwa
2 participants
@scriptex @scriptPilot