Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to built-in Webpack asset management #682

Closed
scriptex opened this issue Nov 8, 2021 · 0 comments · Fixed by #688
Closed

Switch to built-in Webpack asset management #682

scriptex opened this issue Nov 8, 2021 · 0 comments · Fixed by #688
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@scriptex
Copy link
Owner

scriptex commented Nov 8, 2021

Assets such as fonts, images, etc should be handled using the built-in Webpack asset manager, not the file-loader.

{
	test: /\.(jpe?g|gif|png|svg|woff2?|ttf|eot|wav|mp3|mp4)(\?.*$|$)/,
	type: 'asset/resource'
}

Also, the bundles' file name should be changed to dist/[NAME].[EXT] to [NAME].[EXT]. This applies to both the JS and the CSS bundle.

@scriptex scriptex added bug Something isn't working enhancement New feature or request labels Nov 8, 2021
@scriptex scriptex self-assigned this Nov 8, 2021
@scriptex scriptex linked a pull request Nov 16, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant