新增脚本支持顶级await #258
Merged
新增脚本支持顶级await #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
调用的地方不多，应该没问题不大，先合了，近期有计划修下之前的bug发个fix版本 |
| @@ -17,7 +17,7 @@ export function compileScriptCode(scriptRes: ScriptRunResouce): string { | |||
| }); | |||
| } | |||
| code = require + code; | |||
| return `with (context) return (()=>{\n${code}\n//# sourceURL=${chrome.runtime.getURL( | |||
| return `with (context) return (async ()=>{\n${code}\n//# sourceURL=${chrome.runtime.getURL( | |||
There was a problem hiding this comment.
我有个问题，这样相当于把脚本注入做成了异步，在比较严格要求document.start的脚本中会不会出现问题？
There was a problem hiding this comment.
脚本注入是在window上挂载一个闭包函数，然后执行。
这段代码外部还有一个闭包函数，这段代码只是在闭包中把同步改成异步，不影响闭包外代码。
There was a problem hiding this comment.
我就是指的闭包内的这个代码，整个闭包相当于成为了异步，执行的优先级被拉低了，变成了微任务队列
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
简单测试了下没啥问题
不清楚是否会引起蝴蝶效应