Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tables #7

Closed
DavidSoy opened this issue Mar 31, 2016 · 1 comment
Closed

Create tables #7

DavidSoy opened this issue Mar 31, 2016 · 1 comment

Comments

@DavidSoy
Copy link

We are implementing the standard UX using the PrestUI library. We are showing a table using the example of github (https://github.com/Scritik/prestui/wiki/Tables) but the table does not show the rows; it only shows the header. Debbugging the code for displaying the table (ps-table.tpl) we found that the error should be on the line 66:

    
        
            { row[value] }
        
        
            
                
                                              { this.primary_action.title }                                                                                                                               
            
             

Specifically in the loop columns nested within the loop of the rows. The variable this.columns_keys is apparently being ignored because is nested within a loop. If we change the variable this.columns_keys and we put the variable row in its place, declared in the upper loop, the rows of the table are shown.

This also happens with the action buttons for each row. The condition of the line 69 (if={ this.primary_action }) is always false because that variable seems not to exist in that loop.

We would appreciate a more extensive documentation and examples of PrestUI to display tables.

@Scritik
Copy link
Owner

Scritik commented Apr 2, 2016

Hi,

Can you show me a PHP sample to reproduce you bug? I'm using ps-table in several modules and I don't have any issue with it and I can't really understand exactly where is this issue.
Also, can you test with the dev branch? I have recently made a patch on empty tables but if I understand well you case, this is not the solution to your problem.

Regarding the documentation, what do you need more? You have a PHP sample on how to create the array and then a Smarty sample to display the array.

@Scritik Scritik closed this as completed May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants