Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onScrollChange callback #1040

Merged
merged 1 commit into from
Mar 9, 2023
Merged

feat: add onScrollChange callback #1040

merged 1 commit into from
Mar 9, 2023

Conversation

arturbien
Copy link
Contributor

@arturbien arturbien commented Mar 7, 2023 •
edited
Loading

This PR adds support for onScrollChange callback.
Backwards compatibility kept because the callback argument is optional.

This callback allows for orchestrating animations that depend on the scrolling state.
Example usage below:

Screen.Recording.2023-03-07.at.11.58.43.mov

(cc @stipsan @procot )

@arturbien
Copy link
Contributor Author

@stipsan @procot I'd really appreciate if you take a look at this PR. We've forked this library in one of our project just to make that feature and I think its worth adding to this library so other people could benefit from it too :)

stipsan
stipsan approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Look's great! 😄

@stipsan stipsan merged commit a6ad6ff into scroll-into-view:main Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stipsan stipsan stipsan approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arturbien @stipsan