Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backlog: updates needed for next circuit release #109

Closed
lispc opened this issue May 29, 2022 · 1 comment · Fixed by #497
Closed

backlog: updates needed for next circuit release #109

lispc opened this issue May 29, 2022 · 1 comment · Fixed by #497

Comments

@lispc
Copy link

lispc commented May 29, 2022 •
edited

  1. rebase traceing memory size updates from upstream core/vm: for tracing, do not report post-op memory ethereum/go-ethereum#24867
  2. disable memory trace (to allow bigger blocks)

Need to do them when integrating with NEXT scroll-dev-MMDD circuit release
@lispc lispc changed the title backlog: rebase https://github.com/ethereum/go-ethereum/pull/24867 backlog: rebase traceing memory size updates from upstream May 29, 2022
@lispc lispc changed the title backlog: rebase traceing memory size updates from upstream backlog: updates needed for next circuit release Jun 14, 2022
@lispc
Copy link
Author

lispc commented Jun 15, 2022

we can rebase our patches on v1.10.18 later

v1.10.18 is the first version including refund in StructLog
v1.10.19 brings too much changes in trie

@lispc lispc reopened this Aug 31, 2023
@lispc lispc linked a pull request Aug 31, 2023 that will close this issue
fix(trace): fix memory trace size #497
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(trace): fix memory trace size scroll-tech/go-ethereum
2 participants
@lispc @29988122