Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added redhat/centos spec file #17

Merged
merged 5 commits into from Mar 26, 2014
Merged

Added redhat/centos spec file #17

merged 5 commits into from Mar 26, 2014

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Mar 19, 2014

Please have a look and let me know if you have any questions.

@joto
Copy link
Collaborator

joto commented Mar 19, 2014

Your spec file uses cmake to build. The cmake files were provided from a third party for Windows, on Linux we have been using the normal make files. I am not sure the cmake stuff has all the right options etc. Maybe you want to use the make version and/or check whether they are in sync.

@kayrus
Copy link
Contributor Author

kayrus commented Mar 19, 2014

Cmake works well under Linux. As for normal make, I'll implement it in next versions. Thanks!

@joto
Copy link
Collaborator

joto commented Mar 24, 2014

What's the reason for the extra libdir? Maybe we can roll the patch into the source?

@kayrus
Copy link
Contributor Author

kayrus commented Mar 25, 2014

64bit and 32bit architectures have different libdir:
/usr/lib64
and
/usr/lib

@joto
Copy link
Collaborator

joto commented Mar 26, 2014

Let's pull that patch into the Makefile then. It doesn't hurt anybody else and everything becomes simpler.

Why are there the extra "mkdir ..." and "install..." lines in the %install section? Shouldn't the "make install" take care of that?

Build requirement for cmake is now not needed make, I guess.

@kayrus
Copy link
Contributor Author

kayrus commented Mar 26, 2014

Fixed.

joto added a commit that referenced this pull request Mar 26, 2014
Added redhat/centos spec file
@joto joto merged commit 08947fd into openstreetmap:master Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants