Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get-GSSheetInfo defaults to include GridData without use of -IncludeGridData #248

Closed
WJurecki opened this issue Nov 9, 2019 · 2 comments
Closed

Get-GSSheetInfo defaults to include GridData without use of -IncludeGridData #248

WJurecki opened this issue Nov 9, 2019 · 2 comments
Assignees
@scrthq
Labels
bug

Comments

@WJurecki
Copy link
Contributor

WJurecki commented Nov 9, 2019

Get-GSSheetInfo -SpreadsheetId '1rhsAYTOB_vrpvfwImPmWy0TcVa2sgmQa_9u976'

returns GridData without the use of the -IncludeGridData parameter.

To get SheetInfo without GridData the following command needs to be used.

Get-GSSheetInfo -SpreadsheetId '1rhsAYTOB_vrpvfwImPmWy0TcVa2sgmQa_9u976' -IncludeGridData:$false

This functionality is not intuitive.

This functionality causes Export-GSSheet to take a long period of time to execute when operated against a very large existing spreadsheet because line 187 of Export-GSSheet does not include -IncludeGridData:$false

My request is to either fix the counterintuitive functionality of -IncludeGridData parameter on Get-GSSheetInfo or add -IncludeGridData:$false to line 187 of Export-GSSheet
@scrthq
Copy link
Member

scrthq commented Nov 11, 2019

Checking this out, thank you @WJurecki !! Completely makes sense!

@scrthq scrthq self-assigned this Nov 11, 2019
@scrthq scrthq added the bug label Nov 11, 2019
scrthq added a commit that referenced this issue Nov 25, 2019
@scrthq
saving work for issue #248 so far
32b0268
@scrthq scrthq mentioned this issue Dec 29, 2019
Merged
scrthq added a commit that referenced this issue Dec 29, 2019
@scrthq
!deploy v2.35.0
82bee3b 
## 2.35.0 - 2019-12-29

* [Issue #216](#216) - _Thank you, [@WJurecki](https://github.com/WJurecki)!_
    * Added `Add-GSSheetValues` to use the native `Append()` method instead of `BatchUpdate()` to prevent needing to calculate the last row like you do with `Export-GSSheet`. Since the input for this method has additional options and the output differs from what `Export-GSSheet` outputs, this has been moved to a unique function to prevent introducing breaking changes to `Export-GSSheet`.
* [Issue #221](#221)
    * Added: `Invoke-GSUserOffboarding` function to wrap common offboarding tasks for ease of access management automation.
* [Issue #248](#248)
    * Fixed `Get-GSSheetInfo` so it no longer defaults `-IncludeGridData` to `$true` if not specified in `$PSBoundParameters`.
* [Issue #249](#249)
    * Updated private function `Resolve-Email` with new `IsGroup` switch, then cleaned up all `*-GSGroup*` functions to use it so that Group ID's are respected based on RegEx match.
* [Issue #252](#252)
    * Added: `Archived` parameter to `Update-GSUser` to enable setting of Archived User licenses.
* Miscellaneous
    * Swapped instances of `Get-StoragePath` for `Get-ConfigurationPath` in `Import-SpecificConfiguration` and `Set-PSGSuiteConfig` to avoid alias related issues with PowerShell 4.0
@scrthq
Copy link
Member

scrthq commented Dec 29, 2019

Hey @WJurecki - v2.35.0 has added the fix(es) for this. Get-GSSheetInfo was actually forcing IncludeGridData to $true if not set in $PSBoundParameters, so I removed that to follow expectations. I've also explicitly set -IncludeGridData:$false in the internal call to Get-GSSheetInfo on Export-GSSheetInfo to cover bases there in the odd event that the first fix is reverted down the line for some reason.

@scrthq scrthq closed this as completed Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scrthq scrthq

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scrthq @WJurecki