Skip to content
This repository has been archived by the owner on Jun 21, 2020. It is now read-only.

ipcMessages: Bug regarding the packed message in a ptt request #38

Closed
AvishaiW opened this issue Jan 27, 2019 · 3 comments
Closed

ipcMessages: Bug regarding the packed message in a ptt request #38

AvishaiW opened this issue Jan 27, 2019 · 3 comments
Assignees

Comments

@AvishaiW
Copy link
Contributor

AvishaiW commented Jan 27, 2019

the packed message received in the PTTRequest, according to the p2p docs looks like this:
{ prefix: b"Enigma Message", data: [addresses], pubkey: 'DH pubkey', id: '12-bytes-msgID', }
however, when I receive the actual data and deserialize it, according to this and this i get the following Value:

Object({"data": Object({"Request": Array([Array([Number(184), Number(9), Number(232), Number(63), Number(130), Number(214), Number(28), Number(214), Number(130), Number(77), Number(79), Number(244), Number(147), Number(127), Number(95), Number(111), Number(252), Number(140), Number(93), Number(183), Number(224), Number(201), Number(13), Number(215), Number(20), Number(185), Number(81), Number(102), Number(32), Number(217), Number(206), Number(55)]), Array([Number(117), Number(37), Number(131), Number(36), Number(68), Number(25), Number(63), Number(109), Number(70), Number(224), Number(116), Number(37), Number(219), Number(237), Number(51), Number(69), Number(4), Number(219), Number(16), Number(248), Number(151), Number(231), Number(8), Number(153), Number(89), Number(200), Number(42), Number(52), Number(53), Number(10), Number(228), Number(199)])])}), "id": Array([Number(36), Number(206), Number(141), Number(207), Number(13), Number(151), Number(215), Number(212), Number(82), Number(115), Number(227), Number(232)]), "prefix": Array([Number(69), Number(110), Number(105), Number(103), Number(109), Number(97), Number(32), Number(77), Number(101), Number(115), Number(115), Number(97), Number(103), Number(101)]), "pubkey": Array([Number(236), Number(223), Number(151), Number(150), Number(147), Number(82), Number(22), Number(85), Number(130), Number(30), Number(174), Number(181), Number(54), Number(106), Number(121), Number(197), Number(192), Number(128), Number(216), Number(54), Number(181), Number(254), Number(196), Number(162), Number(232), Number(8), Number(30), Number(29), Number(64), Number(64), Number(187), Number(70), Number(192), Number(34), Number(42), Number(145), Number(251), Number(67), Number(245), Number(195), Number(42), Number(67), Number(24), Number(197), Number(146), Number(62), Number(48), Number(232), Number(89), Number(205), Number(137), Number(217), Number(206), Number(226), Number(62), Number(231), Number(183), Number(123), Number(84), Number(225), Number(141), Number(206), Number(226), Number(51)])})

which is a value that contains bytes

@AvishaiW
Copy link
Contributor Author

In the packed message received by the ptt request, the struct is in the following format:

{
    prefix: b"Enigma Message",
    data: Request: [addresses],
    pubkey: 'DH pubkey',
    id: '12-bytes-msgID',
}

we need the Request removed. (tried to fix it myself but didn't find the right location to do that.)

@elichai
Copy link
Contributor

elichai commented Jan 28, 2019

First is solved.
I'll flatten the enum to solve the second

@elichai
Copy link
Contributor

elichai commented Jan 29, 2019

Ok, So after discussion with @AvishaiW we decided it's not a bug because there are no third party's involved here, it's serialized and deserialized in the same struct/enum in both sides.

@elichai elichai closed this as completed Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants