CW 1.0, User inputs must be deserialized into String, not Addr.

[denismaxim0v]

Currently this branch has the updated code that ports the implementation to cosmwasm 1.0, however the changes made seem to be wrong. Cosmwasm docs state:

The new type Addr was created to hold validated addresses. Those can be created via Addr::unchecked, Api::addr_validate, Api::addr_humanize and JSON deserialization. In order to maintain type safety, deserialization into Addr must only be done from trusted sources like a contract's state or a query response. User inputs must be deserialized into String.

Addr must not be used in messages sent by the user because this would result in unvalidated instances.

User inputs such as

TransferFrom {
        owner: Addr,
        recipient: Addr,
        amount: Uint128,
        memo: Option<String>,
        padding: Option<String>,
}

Should deserialize into strings instead of Addr and then validated using addr_validate. Please refer to the original cw20 implementation here

 TransferFrom {
        owner: String,
        recipient: String,
        amount: Uint128,
},

[toml01]

Thanks @denismaxim0v you are correct.
Keep in mind that the V1 version of snip20 implementation is still WIP, so use at your own risk

cc @eladr7

[eladr7]

@denismaxim0v Thank you Denis.
I updated the PR accordingly.