Reactive extension options #210

Chrissi2812 · 2019-02-25T15:27:34Z

This allows something like this which will call the update method of that extensions.

this.editor.extensions.options.placeholder.emptyNodeText = newValue

This will close #153

Example

~~If the content is not empty the state get's mismatched, and everything is screwed up 😩~~ fixed with 89e6436 and 0f44e74

changing options will call the update method off the extension.

using view.state instead

philippkuehn · 2019-03-06T05:49:23Z

This one is great! Thanks a lot!

Chrissi2812 added 6 commits February 25, 2019 16:20

make options for extensions reactive

45945e2

changing options will call the update method off the extension.

add update method to placeholder

5b77907

changed placeholder example for reactive placeholder

7762316

state passed to ExtensionManager is not updated

89e6436

using view.state instead

fixed placeholder change corrupts current state

0f44e74

adding update method of extensions to readme

0f64e2e

Chrissi2812 marked this pull request as ready for review February 26, 2019 10:53

Chrissi2812 added 2 commits February 26, 2019 11:56

removed unnecessary comment

1cd40d3

travis-ci fixed praram-reassign issue in proxy setter

1dbf542

philippkuehn merged commit bafa4a6 into ueberdosis:master Mar 6, 2019

ifiokjr mentioned this pull request Mar 9, 2019

Enable updates to extension options via props remirror/remirror#41

Closed

Chrissi2812 deleted the reactive-plugin-options branch April 25, 2019 15:34