-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use wildcard pub re-export #430
Labels
Comments
When I tried to integrate the refactored api-client into the worker, I thought that the exports are in general kind of a chaos. |
Check wildcard re-export and re-export only "important" items (for example used in the examples) to make them easily searchable/accessible in the public API
|
Note:
WsRpcClient API:
TungsteniteRpcClient API:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This can easily lead to exports of the same named struct, such as
Error
and co (see #424 (comment)).A cleaner way would be to re-export everything that should be public specifically.
The text was updated successfully, but these errors were encountered: