Investigate: What dependencies should be made optional

[clangenb]

Like contracts, staking and rustls stuff.

This will remove quite some dependencies in case they are not needed.

[haerdib]

Could look similar to staking xt:

substrate-api-client/Cargo.toml

Line 87 in 10084fa

staking-xt = ["std"]

[haerdib]

Should also include:

• what feature flags
• internal dependencies - should all of them always be forwarded?

[Niederb]

For following crates take the longest to compile: wasmparser, wasmtime, wasmparser-nostd, sp-state-machine and wasmi

[clangenb]

If I am not mistaken, they are exclusively used by the pallet-contracts.

[Niederb]

Unfortunately sp-wasm-interface has a dependency on wasmi as well (at least in std mode). See this issue/comment #272 (comment)

[clangenb]

Hmm, I see. However, we did not have these dependencies before in the worker: https://github.com/integritee-network/worker/pull/1263/files

Which intrigues me now.

[Niederb]

Oh, that is interesting indeed. I will do a bit more digging as it would be nice to get rid of them not only for compilation time but also to allow better wasm support.

[clangenb]

Cool, sounds great!

[Niederb]

@clangenb Hmm, I checked and most of the dependencies are not really new if I look at:
https://github.com/integritee-network/worker/blob/945571ae07f6efdebb7cf67b21e5e31b1b4b6ee4/Cargo.lock
Only wasmparser-nostd is completely new wasmi is now duplicated with different version numbers.
One thing I noticed: In the worker there are some dependencies to the substrate-api-client without default-features = false. This now activates the jsonrpsee-client feature which is not what you might want/need. I think disabling the default features could already help a bit with your dependencies. Could you check what happens?

[clangenb]

Nice, this is what happens: https://github.com/integritee-network/worker/pull/1271/files.

So nothing regarding the wasm stuff, but still a nice side-effect.

Yeah, I only checked the diff I must admit, sorry for that. :)

[Niederb]

Great. I was not really expecting to see changes regarding wasm, but at least one of the rustls dependencies is gone 👍