Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe unwraps in macro: Remove or declare as unsafe #705

Closed
haerdib opened this issue Feb 1, 2024 · 0 comments · Fixed by #709
Closed

Unsafe unwraps in macro: Remove or declare as unsafe #705

haerdib opened this issue Feb 1, 2024 · 0 comments · Fixed by #709
Assignees
@haerdib
Labels
F1-security possible vulnerability

Comments

@haerdib
Copy link
Contributor

haerdib commented Feb 1, 2024 •
edited
Loading

Our current macro code compose_extrinsic and compose_call contain unwraps. That's not safe. We should either remove them or mark the macro accordingly.
@haerdib haerdib added the F2-bug Something isn't working label Feb 1, 2024
@haerdib haerdib changed the title compose_extrinsic macro: Remove unwrap or declare as unsafe unsafe unwraps in macro: Remove or declare as unsafe Feb 1, 2024
@haerdib haerdib changed the title unsafe unwraps in macro: Remove or declare as unsafe Unsave unwraps in macro: Remove or declare as unsafe Feb 1, 2024
@haerdib haerdib changed the title Unsave unwraps in macro: Remove or declare as unsafe Unsafe unwraps in macro: Remove or declare as unsafe Feb 6, 2024
@haerdib haerdib self-assigned this Feb 6, 2024
@haerdib haerdib mentioned this issue Feb 6, 2024
Merged
@haerdib haerdib added F1-security possible vulnerability and removed F2-bug Something isn't working labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haerdib haerdib

Labels
F1-security possible vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Macros: Return optional extrinsic instead of unwrapping scs/substrate-api-client
1 participant
@haerdib