Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sass modules #55

Open
stof opened this issue Nov 4, 2019 · 6 comments
Open

Support for sass modules #55

stof opened this issue Nov 4, 2019 · 6 comments
Labels
enhancement New feature or request spec compliance Issues with compliance to the Sass spec

Comments

@stof
Copy link
Member

stof commented Nov 4, 2019

Modules are the new way of organizing sass files, current available in dart-sass. See http://sass.logdown.com/posts/7858341-the-module-system-is-launched for the announcement.

Is there any plan for implementing them in scssphp ?

@robocoder
Copy link
Member

robocoder commented Nov 4, 2019

By "plan", do you mean something more concrete than a wish/todo list? ;)

Off-hand, implementing @use/@forward looks non-trivial.

@stof
Copy link
Member Author

stof commented Nov 5, 2019

it is indeed non-trivial. And currently, libsass does not have support for it yet either (only the reference implementation dart-sass has it for now).
But I expect that libraries will start looking into it (there is already some discussion about it on material-components-web for instance).

Non-support in libsass might still be considered as a blocker for now by many projects, due to node-sass (the libsass binding) being used a lot more than sass (the dart-sass JS distribution) for projects managing their tooling via npm (see https://www.npmtrends.com/node-sass-vs-sass). But the trend seems to be in favor of dart-sass (node-sass having lots of existing projects which haven't switched their implementation just because dart-sass is released).

@Cerdic
Copy link
Collaborator

Cerdic commented Nov 27, 2019

Definitely a huge re-work of ScssPHP will be needed.
Time will say if someone is able to get enough available time to go on it.

@phuclh
Copy link

phuclh commented Sep 2, 2022

Any updates on this? Thank you!

@stof
Copy link
Member Author

stof commented Sep 2, 2022

@phuclh this won't happen in 1.x. The code of scssphp is too messy (and too far from being spec compliant) to add modules in it.

The work on 2.0 is in progress, rewriting the compiler based on the dart-sass code, bringing us to spec compliance. Once this is done (no ETA as I'm doing that on my free time), supporting modules will be the next big work (so probably coming in 2.1.0 or 2.2.0).
See https://github.com/scssphp/scssphp/milestone/2?closed=1 for the work already done on it.

@phuclh
Copy link

phuclh commented Sep 2, 2022

@phuclh this won't happen in 1.x. The code of scssphp is too messy (and too far from being spec compliant) to add modules in it.

The work on 2.0 is in progress, rewriting the compiler based on the dart-sass code, bringing us to spec compliance. Once this is done (no ETA as I'm doing that on my free time), supporting modules will be the next big work (so probably coming in 2.1.0 or 2.2.0).
See https://github.com/scssphp/scssphp/milestone/2?closed=1 for the work already done on it.

Thank you for quick response and good to know you are working on the version 2 😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spec compliance Issues with compliance to the Sass spec
Projects
None yet
Development

No branches or pull requests

4 participants