Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECN support with old chunk format #594

Closed
kanakagrawal opened this issue Jun 23, 2021 · 2 comments
Closed

ECN support with old chunk format #594

kanakagrawal opened this issue Jun 23, 2021 · 2 comments
Assignees
Labels

Comments

@kanakagrawal
Copy link

Hi,

We are using usrsctp to run sctp server. When connecting with linux kernel sctp client, sometimes, when there is congestion in the network, client sends ECNE packets but there is no reply to that by usrsctp. On looking at the source code, there is a check of chunk length here. This is causing the ECNE packets to be dropped at usrsctp and no reply is sent.

I know that we can just disable ECN support but we would like to have this feature and compatible with linux kernel sctp. Any ideas on how to fix it?

@tuexen tuexen self-assigned this Jun 23, 2021
@tuexen tuexen added the bug label Jun 23, 2021
@tuexen
Copy link
Member

tuexen commented Jun 23, 2021

Yepp, that check is too restrictive. Will fix that later today.

@tuexen tuexen closed this as completed in de7d903 Jun 23, 2021
@tuexen
Copy link
Member

tuexen commented Jun 23, 2021

Please report if the above commit fixes the issue you. Thanks for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants