Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onChangeComplete Doesn't really work when color drag is completed #288

Open
njofce opened this issue May 25, 2020 · 4 comments
Open

onChangeComplete Doesn't really work when color drag is completed #288

njofce opened this issue May 25, 2020 · 4 comments

Comments

@njofce
Copy link

njofce commented May 25, 2020

There is an issue with onChangeComplete. Try dragging the color picker around, or just the opacity indicator, and it gets triggered multiple times. It should only be triggered when the user stops dragging

@scttcper
Copy link
Owner

its a debounced event as opposed to a rapid fire, this is how both react-color and this library implement the onChangeComplete

@njofce
Copy link
Author

njofce commented May 28, 2020

@scttcper
Yes, but I think it's not the desired behavior. I checked the entire library, and I guess some major changes are required to support this. I would like to try a PR, but please let me know if you have a better/faster solution for this.

@KlausHans
Copy link

I agree. I would expect, that onChangeComplete only triggers if the user releases the mouse button (or raises his finger).

@scttcper
Copy link
Owner

There's probably room for an onMouseUp event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants