Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to angular 8 #699

Merged
merged 10 commits into from Sep 25, 2019
Merged

feat: upgrade to angular 8 #699

merged 10 commits into from Sep 25, 2019

Conversation

scttcper
Copy link
Owner

BREAKING CHANGE: requires angular 8

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #699 into master will decrease coverage by 7.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage    62.5%   55.15%   -7.35%     
==========================================
  Files          19       19              
  Lines         608      504     -104     
  Branches       95       92       -3     
==========================================
- Hits          380      278     -102     
- Misses        190      192       +2     
+ Partials       38       34       -4
Impacted Files Coverage Δ
src/lib/toastr/toast.component.ts 71.42% <ø> (-2.89%) ⬇️
src/app/notyf.toast.ts 100% <ø> (ø) ⬆️
src/lib/toastr/toastr.service.ts 46.8% <100%> (-5.53%) ⬇️
src/lib/portal/portal.ts 52.63% <0%> (-17.37%) ⬇️
src/lib/toastr/toast.directive.ts 50% <0%> (-16.67%) ⬇️
src/lib/overlay/overlay-ref.ts 75% <0%> (-12.5%) ⬇️
src/lib/toastr/toastr.module.ts 57.14% <0%> (-9.53%) ⬇️
src/app/pink.toast.ts 55.55% <0%> (-8.09%) ⬇️
src/app/home/home.component.ts 60.31% <0%> (-7.69%) ⬇️
src/lib/overlay/overlay-container.ts 72.72% <0%> (-7.28%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9aeeb7...9e1e345. Read the comment docs.

@scttcper scttcper merged commit ebfa559 into master Sep 25, 2019
@scttcper scttcper deleted the angular-8 branch September 25, 2019 06:02
@scttcper
Copy link
Owner Author

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant