Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add generic for payload in IndividualConfig #980

Merged
merged 1 commit into from Mar 3, 2023

Conversation

twittwer
Copy link
Contributor

@twittwer twittwer commented Mar 2, 2023

relates #904

Add generic to payload in IndividualConfig to enable stricter typing.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: +0.39 🎉

Comparison is base (efaf809) 55.11% compared to head (9b88f9e) 55.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage   55.11%   55.51%   +0.39%     
==========================================
  Files          19       19              
  Lines         508      508              
  Branches       88       88              
==========================================
+ Hits          280      282       +2     
  Misses        216      216              
+ Partials       12       10       -2     
Impacted Files Coverage Δ
src/lib/toastr/toastr.service.ts 51.04% <0.00%> (+2.08%) ⬆️
src/lib/toastr/toast.component.ts 73.95% <100.00%> (ø)
src/lib/toastr/toastr-config.ts 94.73% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scttcper scttcper changed the title Add generic for payload in IndividualConfig feat: Add generic for payload in IndividualConfig Mar 3, 2023
@scttcper scttcper merged commit 815e1dd into scttcper:master Mar 3, 2023
@scttcper
Copy link
Owner

scttcper commented Mar 3, 2023

🎉 This PR is included in version 16.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Dixyx pushed a commit to Dixyx/ngx-toastr that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants