entry is invalid when last response is null.

scull7 · May 5, 2014 · 024961e · 024961e
1 parent 0fa88a3
commit 024961e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/lib/entry.js b/lib/entry.js
@@ -25,6 +25,9 @@ Entry.prototype = {
   // @param {number} ttl
   // @return {boolean}
   'isValid': function (ttl) {
+    if (!this.last) {
+      return false;
+    }
     var now = (new Date()).getTime();
     return (now - this.time) < ttl ? true : false;
   },

diff --git a/lib/queue.js b/lib/queue.js
@@ -27,6 +27,7 @@ Queue.prototype = {
       done = this.getHandler(entry);
 
       if(!entry.isActive()) {
+        entry.active = 1;
         task(null, done);
       }
     }

diff --git a/test/lib/entry.spec.js b/test/lib/entry.spec.js
@@ -47,9 +47,22 @@ describe('Entry', function () {
   });
 
   describe('isValid', function () {
+    var clock;
+
+    beforeEach(function () {
+      clock = sinon.useFakeTimers();
+    });
+    afterEach(function () {
+      clock.restore();
+    });
     it('should return false on a newly initialized object.', function () {
       expect(entry.isValid()).to.be.false;
     });
+    it('should return false when the time to live has expired.', function () {
+      entry.time = ((new Date()).getTime() - 501);
+      entry.last = 'something';
+      expect(entry.isValid(500)).to.be.false;
+    });
   });
 
   it('should have an isActive function', function () {